maemo.org - Talk - fMMS declined to download while roaming

maemo.org - Talk (https://talk.maemo.org/index.php)

- Maemo 5 / Fremantle (https://talk.maemo.org/forumdisplay.php?f=40)

- - fMMS declined to download while roaming (https://talk.maemo.org/showthread.php?t=97825)

Re: fMMS declined to download while roaming

I've got one silly question. Where is the fmms source code repository? Or do you just edit the onphone python files?

Re: fMMS declined to download while roaming

Quote:

Originally Posted by shubell (Post 1518894)

I've got one silly question. Where is the fmms source code repository?

Have you checked the package page?

Quote:

Or do you just edit the onphone python files?

Or :D

Re: fMMS declined to download while roaming

Some more links (courtesy of Ilew):

Package page at:
http://maemo.org/packages/view/fmms/

frals' original fmms (missing last/my changes but has the non-binary translation files):
https://github.com/frals/fmms

frals' project (1.3.4 is the latest):
https://garage.maemo.org/projects/fmms/

Some new decoding fmms patch:
https://bugs.maemo.org/show_bug.cgi?id=12733

Some python messaging mms with seems to be based on fMMS mms code:
https://github.com/pmarti/python-mes.../messaging/mms

I myself just used the 'OR'!
So latest/current code can be found here:
http://maemo.org/packages/source/vie.../fmms/1.3.6-1/

Re: fMMS declined to download while roaming

I just grabbed the source from peterleinchen's last link.
However it is missing the source translation files.

I have pending maintainership for fMMS, so I should be able to push my fixes soon.

edit: I do my changes/small tests on my computer first then copy over the files to my phone when I'm ready to test actually sending MMSs.

Re: fMMS declined to download while roaming

Pending request approved.

Re: fMMS declined to download while roaming

well i did a fork on github and merged all the changes. I also included the decoding patch in.

Re: fMMS declined to download while roaming

Quote:

Originally Posted by shubell (Post 1520612)

well i did a fork on github and merged all the changes. I also included the decoding patch in.

Very nice, you beat me to it.
I was making my own fMMS git and push some new PEP8 changes (I also dislike TABs). (I really should do that soon.)

With the patches that you've applied, do you have anyway to test that they work?

Re: fMMS declined to download while roaming

well the mms decofing patches are from here
https://bugs.maemo.org/show_bug.cgi?id=12733

things should work :) but did not test them. Even if they don't the basic functionality does not change as it only adds some new ones ;)

Re: fMMS declined to download while roaming

Quote:

Originally Posted by shubell (Post 1520770)

Well having a quick look at it, there's a possible problem with the changes to decodeWellKnownCharset method.
(Besides the original problem with the 'decodcedCharSet' typo. Though that may/may not be an actual problem)

Hopefully I got this correct as it's a bit tricky.

Encoded-String-Value can be sent as either 'Text-string or Value-length, Char-set, Text-string'

So if it's octet 127 instead of 128, then we aren't using a charset and we should be using either '*' or ''.
See :

Code:

The special value "*", if present in the Accept-Charset field, matches every character set (including ISO-8859-1) which is not mentioned elsewhere in the Accept-Charset field. If no "*" is present in an Accept-Charset field, then all character sets not explicitly mentioned get a quality value of 0, except for ISO-8859-1, which gets a quality value of 1 if not explicitly mentioned.



If no Accept-Charset header is present, the default is that any character set is acceptable. If an Accept-Charset header is present, and if the server cannot send a response which is acceptable according to the Accept-Charset header, then the server SHOULD send an error response with the 406 (not acceptable) status code, though the sending of an unacceptable response is also allowed.

The patch above is matching with all charsets if one is given and trying to match a specific charset when none is given.
Which doesn't make sense.

Hopefully someone can chime in if I got anything wrong.

Re: fMMS declined to download while roaming

Quote:

Originally Posted by Ilew (Post 1520789)

...
Hopefully I got this correct as it's a bit tricky.

...

The patch above is matching with all charsets if one is given and trying to match a specific charset when none is given.
Which doesn't make sense.

Hopefully someone can chime in if I got anything wrong.

And that was the reason why I did not included/used this patch. I also did not get it completely and must say (to my shame) that I understand even less today what it really should patch ...